-
Notifications
You must be signed in to change notification settings - Fork 948
clnrest: add more request and response types #8383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clnrest: add more request and response types #8383
Conversation
36b5d63
to
3c27f6d
Compare
BTW, the PR is clearly WIP but thought to post my test cases here for future review. Feel free to use them in test suite if they seem helpful.
|
3c27f6d
to
733601e
Compare
I've added support for different request types (except html, how would that work?). I also added some tests and improved the documentation/compatibility with the swagger ui. |
haha what is the CI smoking:
|
733601e
to
277730d
Compare
For now, we can proceed without adding |
277730d
to
7e44466
Compare
Apparently this isn't a weird CI bug but liquid just doesn't allow p2tr addresses (Is this known?). I've added a skip on liquid for those tests.
Yes, i removed the html type from responses. |
7e44466
to
5d639ee
Compare
rebased and got a clean ci run. iirc previous ci errors were unrelated. |
9e64f68
to
8b6b2c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack 8b6b2c1.
8b6b2c1
to
b657c17
Compare
Changelog-Added: clnrest can now return successful responses as xml, yaml, or form-encoded in addition to json defined in the 'Accept' header. The same goes for request types defined in the 'Content-type' header.
b657c17
to
b5c4107
Compare
bf37d41
into
ElementsProject:master
Changelog-Added: clnrest can now return successful responses as xml, yaml, html or form-encoded in addition to json defined in the 'Accept' header. The same goes for request types except for html defined in the 'Content-type' header.
Important
25.09 FREEZE July 28TH: Non-bugfix PRs not ready by this date will wait for 25.12.
RC1 is scheduled on August 11th
The final release is scheduled for September 1st.
Fixes #7164
Right now the html response type is just the json wrapped as text in an html body and for requests i did not add html.
Checklist
Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked: